Re: [PATCH] serial.c procfs kudzu - discussion

From: Russell King (rmk@arm.linux.org.uk)
Date: Fri Mar 08 2002 - 04:49:18 EST


On Thu, Mar 07, 2002 at 03:12:54PM -0800, Ed Vance wrote:
> This is not the result of a recent change to the serial driver. I don't
> know how far back this bug goes, but I suspect it is as old as the proc
> fs serial support.

I think there are two bugs here that need treating in different ways.

1. Not displaying port statistics for iomem-based ports. This is
   probably an oversight when iomem ports were added to the serial
   driver.

2. "port:" entry being 0. I don't think we really want to report IO
   port or memory addresses here without giving userspace some
   indication which we're reporting.

For 2, I'd suggest replacing "port:" with "mem:" for iomem ports, and
changing the serinfo: line to reflect the changed format (this is
probably ignored by kudzu though.)

Does this sound reasonable?

-- 
Russell King (rmk@arm.linux.org.uk)                The developer of ARM Linux
             http://www.arm.linux.org.uk/personal/aboutme.html

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Fri Mar 15 2002 - 22:00:07 EST