Re: [PATCH] boot_cpu_data corruption on SMP x86

From: Maciej W. Rozycki (macro@ds2.pg.gda.pl)
Date: Thu Mar 21 2002 - 15:01:39 EST


On Thu, 14 Mar 2002, Mikael Pettersson wrote:

> --- linux-2.4.19-pre3/arch/i386/kernel/head.S.~1~ Tue Feb 26 13:26:56 2002
> +++ linux-2.4.19-pre3/arch/i386/kernel/head.S Thu Mar 14 16:20:57 2002
> @@ -178,7 +178,7 @@
> * we don't need to preserve eflags.
> */
>
> - movl $3,X86 # at least 386
> + movb $3,X86 # at least 386
> pushfl # push EFLAGS
> popl %eax # get EFLAGS
> movl %eax,%ecx # save original EFLAGS
> @@ -191,7 +191,7 @@
> andl $0x40000,%eax # check if AC bit changed
> je is386
>
> - movl $4,X86 # at least 486
> + movb $4,X86 # at least 486
> movl %ecx,%eax
> xorl $0x200000,%eax # check ID flag
> pushl %eax

 This is broken -- these word stores assure a proper initialization on
pre-CPUID processors.

-- 
+  Maciej W. Rozycki, Technical University of Gdansk, Poland   +
+--------------------------------------------------------------+
+        e-mail: macro@ds2.pg.gda.pl, PGP key available        +

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sat Mar 23 2002 - 22:00:25 EST