Re: [patch] smaller kernels

From: Marcelo Tosatti (marcelo@conectiva.com.br)
Date: Mon Mar 25 2002 - 17:22:31 EST


On Mon, 25 Mar 2002, Rusty Russell wrote:

> On Tue, 19 Mar 2002 22:11:48 -0800
> Andrew Morton <akpm@zip.com.au> wrote:
>
> > This is the result of a search-and-destroy mission against
> > oft-repeated strings in the kernel text. These come about
> > due to the toolchain's inability to common up strings between
> > compilation units.
>
> The name is horrible. BUG() stands out: perhaps "BUG_LITE()"?
>
> And I'm not sure DaveM'll appreciate this:
>
> > static inline char *__skb_pull(struct sk_buff *skb, unsigned int len)
> > {
> > skb->len-=len;
> > - if (skb->len < skb->data_len)
> > - BUG();
> > return skb->data+=len;
> > }

Andrew,

I've just readded all asserts which you removed... if you really want to
remove any of those, please prove me that they are useless.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sun Mar 31 2002 - 22:00:10 EST