Re: save_flags() should take unsigned long

From: Russell King (rmk@arm.linux.org.uk)
Date: Tue Mar 26 2002 - 11:54:35 EST


On Tue, Mar 26, 2002 at 02:29:55PM +0100, David Weinehall wrote:
> The correct way to fix this would be:
>
> <in suitable header-file; suggestions welcome>
> typedef flags_t unsigned long;

You mean typedef unsigned long flags_t;

However, people will still write:

{
        int flags;

        save_flags(flags);

because 'int' is faster to type than 'flags_t'. About the only way
you're going to stop it dead is to do:

   typedef struct { unsigned long val; } flags_t;

and then save_flags(x)/restore_flags(x) use (x).val

-- 
Russell King (rmk@arm.linux.org.uk)                The developer of ARM Linux
             http://www.arm.linux.org.uk/personal/aboutme.html

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sun Mar 31 2002 - 22:00:11 EST