On Tuesday March 26, mfedyk@matchmail.com wrote:
> On Wed, Mar 27, 2002 at 01:07:00PM +1100, Neil Brown wrote:
> > On Wednesday March 27, afu@fugmann.dhs.org wrote:
> > > Thanks.
> > >
> > > It seems that there is some more problems.
> > > I have not verified the lookup (since I just booted right away with the patch), but
> > > I have found that:
> > >
> > > Mar 26 23:56:58 gw kernel: nfsd: LOOKUP(3) 24: 03000001 03000900 00000002 0000106d 0000106c 0000070d WMRootMenu
> > > Mar 26 23:56:58 gw kernel: RPC request reserved 240 but used 244
> > >
> > > Mar 27 00:30:09 gw kernel: nfsd: CREATE(3) 24: 03000001 03000900 00000002 00000003 00000002 00000000 test
> > > Mar 27 00:30:09 gw kernel: RPC request reserved 272 but used 276
> > >
> > > Mar 27 00:30:21 gw kernel: nfsd: SYMLINK(3) 24: 03000001 03000900 00000002 00000003 00000002 00000000 test1 -> test
> > > Mar 27 00:30:21 gw kernel: RPC request reserved 272 but used 276
> > >
> > > And there might be others.
> >
> > I bet you're using reisferfs ???
> >
> > It occasionaly uses filehandles longer than 32 bytes (the max for
> > NFSv2) and my calculations forgot that nfsv3 allows for 64 bytes.
> > So "9" (8 longs and a count) should be "17" (16 longs and a count).
> >
>
> Why aren't you using defines with comments in effect to the above?
No really good reason.
I think I felt that macros would be very noisy for relatively little
gain.
However I guess
#define ST 1 /* status*/
#define FH 17 /* filehandle with length */
#define AT 22 /* attributes */
#define WC 7 /* WCC attribute prefix */
might make things clearer without being too noisy....
NeilBrown
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Sun Mar 31 2002 - 22:00:12 EST