Re: [CFT][RFC][PATCH][CLEANUP] task->state cleanup: pilot

From: Robert Love (rml@tech9.net)
Date: Sat Apr 06 2002 - 18:41:01 EST


On Sat, 2002-04-06 at 17:06, Paul P Komkoff Jr wrote:
> This is the pilot of task->state cleanup in 2.4.x. Feel free to blame me for
> incorrect use of set_task_state vs. __set_task_state

Nice cleanup. Awful lot of [items] in the subject though :)

You don't have to worry about your choices wrt set_current_state vs
__set_current_state - by using only set_current_state you erred on the
side of caution. set_current_state enforces a memory barrier around the
write on SMP (on UP it is the same code) while __set_current_state does
not.

If anyone can verify where it is safe in this code to use
__set_current_state instead, speak up so Paul can make the micro
optimization accordingly.

        Robert Love

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sun Apr 07 2002 - 22:00:19 EST