Jens Axboe wrote:
>>>>through the request buffer but IDE-CD is passing them through
>>>>request special field... argh!
>>>
>>>
>>>So kill ->special usage in ide-cd and use ->buffer?
>>
>>That's the idea, but the caching code mentioned above
>>is abusing it already in a way I can't grasp wholly immediately.
>
>
> It's most definitely _not_ abusing it, in fact it's a pretty regular
> usage of ->buffer. ide-cd never does highmem I/O, so ->buffer always
> points to the transfer address for a block request.
> cdrom_read_from_buffer() is simply copying data from the internal 2kb
> cache to rq->buffer, eod.
Either way it's ide-floppy doing the abuse then :-(.
I think the best sollution to this is anyway just to remove
the struct packet_command altogeter and just add the required fields
to struct ata_request - makes ata_request bigger but provides much less
pointer tossing as a benefit.
>
-- - phone: +49 214 8656 283 - job: eVision-Ventures AG, LEV .de (MY OPINIONS ARE MY OWN!) - langs: de_DE.ISO8859-1, en_US, pl_PL.ISO8859-2, last ressort: ru_RU.KOI8-R- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Tue Apr 23 2002 - 22:00:21 EST