Re: unnecessary use of set_bit

From: David Brownell (david-b@pacbell.net)
Date: Sat Apr 27 2002 - 09:19:53 EST


> The ohci_hub_status_data() procedure in drivers/usb/host/ohci-hub.c in
> 2.5.11 is broken in a couple of ways: it uses set_bit on a char *
> address and it assumes little-endian byte order in the bitmap.

Greg already submitted my patch to Linus, but I guess it didn't
make it in yet. You'll be glad to know it stopped using set_bit().

Looks like your patch also preserves the API requirement that
the result be in little-endian byte order.

- Dave

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Tue Apr 30 2002 - 22:00:14 EST