Re: [PATCH] reworked IDE/general tagged command queueing

From: Martin Dalecki (
Date: Wed May 01 2002 - 11:02:37 EST

Uz.ytkownik Linus Torvalds napisa?:
> On Wed, 1 May 2002, Jens Axboe wrote:
>>I've rewritten parts of the IDE TCQ stuff to be, well, a lot better in
>>my oppinion. I had to accept that the ata_request and rq->special usage
>>sucked, it was just one big mess.
> Looks good.

Well after a short cross over look at it I agree.
The generic interface looks sane for me as well. However
I will have to look a bit deeper, becouse at the first sight
the double pointer to tag_index looks a bit "overelaborate"
to me. But I may change my opinnion after looking at the
actual usage - so please take this small bit of critique
with a good grain of salt...

+#define BLK_TAGS_PER_LONG (sizeof(unsigned long) * 8)
+struct blk_queue_tag {
struct request **tag_index; /* map of busy tags */
unsigned long *tag_map; /* bit map of free/busy tags */
struct list_head busy_list; /* fifo list of busy tags */
int busy; /* current depth */
int max_depth;

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

This archive was generated by hypermail 2b29 : Tue May 07 2002 - 22:00:11 EST