Re: [PATCH] Replace exec_permission_lite() with inlined vfs_permission()

From: Alexander Viro (
Date: Fri May 03 2002 - 04:09:53 EST

On Fri, 3 May 2002, Paul Menage wrote:

> How about something like the patch below?
> - i_op->permission() now takes an extra argument, "dcache_locked", and
> should return -EAGAIN if it's called with the dcache_lock held and it
> can't handle it.

Argument-dependent locking rules are Wrong. In any case, what does it
buy you compared to extra method? You need to change every instance
since you are adding an argument. Moreover, the thing you had proposed
for procfs means that we'll need to check the argument and grab dcache_lock
if it's 0. Plus similar fun with unlocking.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

This archive was generated by hypermail 2b29 : Tue May 07 2002 - 22:00:19 EST