Re: 2.5.13 IDE and preemptible kernel problems

From: Linus Torvalds (torvalds@transmeta.com)
Date: Fri May 03 2002 - 13:14:51 EST


On Fri, 3 May 2002, Martin Dalecki wrote:

> Uz.ytkownik Andi Kleen napisa?:
> > Hi,
> >
> > When booting an preemptible kernel 2.5.13 kernel on x86-64 I get
> > very quickly an scheduling in interrupt BUG. It looks like the
> > preempt_count becomes 0 inside the ATA interrupt handler. This
> > could happen when save_flags/restore_flags and friends are unmatched
> > and you have too many flags restores in IDE.
>
> Thank you for pointing out. I will re check it.

Martin, may I suggest that the next line of cleanups should be to remove
all vestiges of the old global interrupt locking from the IDE driver?
Including, for example, the crap "PCI method 1" access stuff in CMD640x..

Also, if you turn on spinlock debugging, that tends to help find the
really silly things faster (leaving the harder races to be solved by
brainforce ;)

                Linus

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Tue May 07 2002 - 22:00:20 EST