Re: [PATCH] double flush_page_to_ram

From: David S. Miller (davem@redhat.com)
Date: Thu May 09 2002 - 08:07:03 EST


   From: Hugh Dickins <hugh@veritas.com>
   Date: Thu, 9 May 2002 14:18:49 +0100 (BST)

   On Thu, 9 May 2002, David S. Miller wrote:
> Wrong, consider the case where we do early COW in do_no_page, you miss
> a flush on the new-new page.
   
   Of course we do, and then we don't map it into user address space;
   if it ever gets mapped into user address space later, do_no_page
   does the flush_page_to_ram then.

You miss the fact that if we do an early COW and another process
recently WROTE into that page via a shared MMAP, we will potentially
copy old data into the COW page we use for the current process.

Your changes are wrong and will cause corruption.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Tue May 14 2002 - 12:00:11 EST