Re: [patch 6/15] larger b_size, and misc fixlets

From: Anton Altaparmakov (aia21@cantab.net)
Date: Sun May 19 2002 - 17:59:35 EST

On Sun, 19 May 2002, Andrew Morton wrote:
> Andreas Dilger wrote:
> > On May 19, 2002 12:39 -0700, Andrew Morton wrote:
> > > - printk(KERN_ERR "Buffer I/O error on device %s, logical block %ld\n",
> > > - bdevname(bh->b_bdev), bh->b_blocknr);
> > > + printk(KERN_ERR "Buffer I/O error on device %s, logical block %Ld\n",
> > > + bdevname(bh->b_bdev), (u64)bh->b_blocknr);
> >
> > Not that I'm a 64-bit system user/developer, but it is my understanding
> > that u64 == long on a 64-bit platform, so your cast to u64 does not
> > actually change the type of b_blocknr as far as printk is concerned.
> > You would need to cast it to unsigned long long instead.
>
> Yes, I suppose so. That more closely matches what "%L" does.

/me can't help it: Didn't I say earlier on that one has to use (unsigned)
long long and not u64? (-; But noone would listen...

But to be fully correct, if you want unsigned long long you really ought
to write %Lu not %Ld... (-8

Cheers,
        Anton 

-- 
Anton Altaparmakov <aia21 at cantab.net> (replace at with @)
Linux NTFS maintainer / IRC: #ntfs on irc.openprojects.net
WWW: http://linux-ntfs.sf.net/ & http://www-stu.christs.cam.ac.uk/~aia21/

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

This archive was generated by hypermail 2b29 : Thu May 23 2002 - 22:00:18 EST