do_mmap

From: Thomas 'Dent' Mirlacher (dent@cosy.sbg.ac.at)
Date: Fri May 31 2002 - 08:00:56 EST

Next message: Dan Aloni: "Re: [PATCH] dcache.{c,h} cleanup"
Previous message: Richard B. Johnson: "Re: [PATCH] FAT fs printk() cleanup"
Next in thread: Alan Cox: "Re: do_mmap"
Reply: Alan Cox: "Re: do_mmap"
Reply: DervishD: "Re: do_mmap"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

hi list,

what about the do_mmap/do_mmap_pgoff implementation?
reurn-type: _unsigned_ long (which should be ok cause we've to return
an adress if len == 0)
on error: -ERR_*

and the checks in various places are really strange. - well some
places check for:
        o != NULL
        o > -1024UL
        o ...

guess this nedds some cleanup.

is it possible to have 0 as a valid address? - if not, this should
be the return on errors.

any comments?

-- in some way i do, and in some way i don't.

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Next message: Dan Aloni: "Re: [PATCH] dcache.{c,h} cleanup"
Previous message: Richard B. Johnson: "Re: [PATCH] FAT fs printk() cleanup"
Next in thread: Alan Cox: "Re: do_mmap"
Reply: Alan Cox: "Re: do_mmap"
Reply: DervishD: "Re: do_mmap"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Fri May 31 2002 - 22:00:30 EST