Re: remove mixture of non-atomic operations with page->flags which requires atomic operations to access

From: David S. Miller (davem@redhat.com)
Date: Mon Jun 03 2002 - 05:00:48 EST

   From: William Lee Irwin III <wli@holomorphy.com>
   Date: Mon, 3 Jun 2002 04:00:55 -0700

            if (PageWriteback(page))
                    BUG();
   - ClearPageDirty(page);
   - page->flags &= ~(1<<PG_referenced);
   +
   + page->flags &= ~((1UL << PG_referenced) | (1UL << PG_dirty));

Umm, nevermind. Look at ClearPageDirty, it does
"other stuff" so you can't remove it wholesale.

In the end, the code is as it should be right now.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

This archive was generated by hypermail 2b29 : Fri Jun 07 2002 - 22:00:15 EST