Re: 2.5.20 i2c uses nonexistent linux/i2c-old.h

From: Dave Jones (davej@suse.de)
Date: Wed Jun 05 2002 - 12:17:19 EST


On Wed, Jun 05, 2002 at 06:35:45PM +0100, Alan Cox wrote:
> > drivers/media/video/i2c-old.c:#include <linux/i2c-old.h>
> > drivers/media/video/saa7110.c:#include <linux/i2c-old.h>
> > drivers/media/video/saa7111.c:#include <linux/i2c-old.h>
> > drivers/media/video/saa7185.c:#include <linux/i2c-old.h>
> > drivers/media/video/zr36067.c:#include <linux/i2c-old.h>
> > drivers/media/video/zr36120.h:#include <linux/i2c-old.h>
> >
> > There is no file called i2c-old.h in 2.5.20. These only build because
> > they pick up i2c-old.h from /usr/include/linux :(.
>
> i2c-old was back compatibility for obsolete code from 2.2 into 2.4. Its
> dead its gone, and now folks need to go fix the drivers

Which makes me wonder why it compiled for Keith.
Why is kbuild2.5 expanding <linux/foo.h> to /usr/include/linux/foo.h ?
If $sourcetree/include/linux/foo.h doesn't exist, it should stop
compiling, not look in /usr/include/ for a (obsolete/wrong) alternative.

        Dave.

-- 
| Dave Jones.        http://www.codemonkey.org.uk
| SuSE Labs
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Fri Jun 07 2002 - 22:00:25 EST