Re: [PATCH][2.5] tulip: change device names

• Next message: Alan Cox: "Re: Tyan S2464 (K7 SMP) + EMU10K1 hardlocks"
• Previous message: Andre Bonin: "Re: Tyan S2464 (K7 SMP) + EMU10K1 hardlocks"
• In reply to: Lightweight patch manager: "[PATCH][2.5] tulip: change device names"
• Next in thread: Thunder from the hill: "Re: [PATCH][2.5] tulip: change device names"
• Reply: Thunder from the hill: "Re: [PATCH][2.5] tulip: change device names"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Thanks for the effort, that was a quick turnaround :)

But unfortunately the patch is wrong.

You need to use an index which counts _tulip_ boards, which implies that
the index is local to the driver. Currently the only such counter is
board_idx, which is a variable local to tulip_init_one().

I wonder who the heck this patch is from?? Mikael? The "Lightweight
patch manager" seems neat, but a rather unfriendly person to reply to :)

Regards,

    Jeff

P.S. A ChangeLog entry (in the patch, or to be cut-n-pasted) is missing
also.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

• Next message: Alan Cox: "Re: Tyan S2464 (K7 SMP) + EMU10K1 hardlocks"
• Previous message: Andre Bonin: "Re: Tyan S2464 (K7 SMP) + EMU10K1 hardlocks"
• In reply to: Lightweight patch manager: "[PATCH][2.5] tulip: change device names"
• Next in thread: Thunder from the hill: "Re: [PATCH][2.5] tulip: change device names"
• Reply: Thunder from the hill: "Re: [PATCH][2.5] tulip: change device names"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Fri Jun 07 2002 - 22:00:30 EST