Doubt (bug?) in dup_mmap()

From: Abhishek Nayani (abhi@kernelnewbies.org)
Date: Fri Jun 14 2002 - 12:43:53 EST


Hi all,

        In the function dup_mmap() in kernel/fork.c,

        file = tmp->vm_file;
        if (file) {
                struct inode *inode = file->f_dentry->d_inode;
                get_file(file);
                if(tmp->vm_flags & VM_DENYWRITE)
                        atomic_dec(&inode->i_writecount);

        After this piece of code, shouldn't there be :
        
                else
                        atomic_inc(&inode->i_writecount);

        as this is a read-write mapping ?
        
                                
                                        Bye,
                                                Abhi.
        
Linux Kernel Documentation Project
http://freesoftware.fsf.org/lkdp

        
--------------------------------------------------------------------------------
Those who cannot remember the past are condemned to repeat it - George Santayana
--------------------------------------------------------------------------------
                          Home Page: http://www.abhi.tk
-----BEGIN GEEK CODE BLOCK------------------------------------------------------
GCS d+ s:- a-- C+++ UL P+ L+++ E- W++ N+ o K- w--- O-- M- V- PS PE Y PGP
t+ 5 X+ R- tv+ b+++ DI+ D G e++ h! !r y-
------END GEEK CODE BLOCK-------------------------------------------------------

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sun Jun 23 2002 - 22:00:11 EST