Re: [BUG] [2.4.19-rc1] w9966 doesn't compile

From: Adrian Bunk (bunk@fs.tum.de)
Date: Sat Jun 29 2002 - 11:47:41 EST


On Sat, 29 Jun 2002, Jakob Kemi wrote:

> Hi Rolf and Adrian!

Hi Jakob,

> > > While trying to compile 2.4.19-rc1 the following error occurs:
> > >
> > > w9966.c:68: warning: invalid character in macro parameter name
> > > w9966.c:68: badly punctuated parameter list in `#define'
>...
> > You are using egcs?
> >
> > It seems egcs can't handle the following in lines 68-69:
> >
> > <-- snip -->
> >
> > ...
> > # define DPRINTF(...) do {} while(0)
> > # define DASSERT(...) do {} while(0)
> > ...
> >
> > <-- snip -->
> >
> >
> > Since egcs is a supported compiler someone should fix this before
> > 2.4.19-final comes out.
>...
> Unfortunatley I don't have egcs handy. Would this be a fix for egcs?
>
> --- w9966.c.orig Sat Jun 29 14:23:41 2002
> +++ w9966.c Sat Jun 29 14:50:21 2002
> @@ -65,8 +65,8 @@
> DPRINTF("Assertion failed at line %d.\n", __LINE__);\
> } while (0)
> #else
> -# define DPRINTF(...) do {} while(0)
> -# define DASSERT(...) do {} while(0)
> +# define DPRINTF(f, a...) do {} while(0)
> +# define DASSERT(f, a...) do {} while(0)
> #endif
>
> /*

yes, this patch fixes the compilation for egcs.

> Regards,
> Jakob

Thanks for your fast response and patch
Adrian

--- drivers/media/video/w9966.c.old Sat Jun 29 18:43:39 2002
+++ drivers/media/video/w9966.c Sat Jun 29 18:43:42 2002
@@ -65,8 +65,8 @@
                         DPRINTF("Assertion failed at line %d.\n", __LINE__);\
         } while (0)
 #else
-# define DPRINTF(...) do {} while(0)
-# define DASSERT(...) do {} while(0)
+# define DPRINTF(f, a...) do {} while(0)
+# define DASSERT(f, a...) do {} while(0)
 #endif

 /*

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sun Jun 30 2002 - 22:00:14 EST