Re: [PATCH] 2.5.24 matroxfb off by one error

From: James Simmons (jsimmons@transvirtual.com)
Date: Mon Jul 01 2002 - 12:05:47 EST


Applyed to the fbdev BK tree.

   . ---
   |o_o |
   |:_/ | Give Micro$oft the Bird!!!!
  // \ \ Use Linux!!!!
 (| | )
 /'\_ _/`\
 \___)=(___/

On Sun, 30 Jun 2002, Petr Vandrovec wrote:

> Hi Linus,
> please apply patch below.
>
> It fixes off by one error in getcolreg/setcolreg in matroxfb's
> secondary head driver.
> Thanks,
> Petr Vandrovec
> vandrove@vc.cvut.cz
>
>
> diff -urdN linux/drivers/video/matrox/matroxfb_crtc2.c linux/drivers/video/matrox/matroxfb_crtc2.c
> --- linux/drivers/video/matrox/matroxfb_crtc2.c Fri Jun 21 00:53:48 2002
> +++ linux/drivers/video/matrox/matroxfb_crtc2.c Sat Jun 29 00:09:09 2002
> @@ -29,7 +29,7 @@
> static int matroxfb_dh_getcolreg(unsigned regno, unsigned *red, unsigned *green,
> unsigned *blue, unsigned *transp, struct fb_info* info) {
> #define m2info ((struct matroxfb_dh_fb_info*)info)
> - if (regno > 16)
> + if (regno >= 16)
> return 1;
> *red = m2info->palette[regno].red;
> *blue = m2info->palette[regno].blue;
> @@ -44,7 +44,7 @@
> #define m2info ((struct matroxfb_dh_fb_info*)info)
> struct display* p;
>
> - if (regno > 16)
> + if (regno >= 16)
> return 1;
> m2info->palette[regno].red = red;
> m2info->palette[regno].blue = blue;
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sun Jul 07 2002 - 22:00:07 EST