Re: [PATCH] Shift BKL into ->statfs()

• Next message: Manuel McLure: "Re: Loopback + NFS: files copied partially with bogus error message."
• Previous message: Crutcher Dunnavant: "[PATCH] init_etherdev cleanups"
• In reply to: Matthew Wilcox: "Re: [PATCH] Shift BKL into ->statfs()"
• Next in thread: Alexander Viro: "Re: [PATCH] Shift BKL into ->statfs()"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

>On Tue, Jul 02, 2002 at 06:25:47PM -0700, Paul Menage wrote:
>> This patch removes BKL protection from the invocation of the
>> super_operations ->statfs() method, and shifts it into the filesystems
>> where necessary. Any out-of-tree filesystems may need to take the BKL in
>> their statfs() methods if they were relying on it for synchronisation.
>
>Sure, makes sense to do. For real credit though, let's see how much we
>need the BKL. In ext2's statfs, we reference:
>

I'm sure the BKL can be ripped out further, but I preferred not to risk
breakage in this patch due to unfamiliarity with the locking rules for
particular filesystems - I just left the BKL out of those that were
clearly not touching mutable data. Patches that shrink the BKL usage for
individual filesystems can be sent (hopefully with copious
justifications) once this or something like it is applied.

Paul

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

• Next message: Manuel McLure: "Re: Loopback + NFS: files copied partially with bogus error message."
• Previous message: Crutcher Dunnavant: "[PATCH] init_etherdev cleanups"
• In reply to: Matthew Wilcox: "Re: [PATCH] Shift BKL into ->statfs()"
• Next in thread: Alexander Viro: "Re: [PATCH] Shift BKL into ->statfs()"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Sun Jul 07 2002 - 22:00:10 EST