Re: usb storage cleanup

From: Matthew Dharm (mdharm-kernel@one-eyed-alien.net)
Date: Wed Jul 03 2002 - 16:43:29 EST

Next message: Tim Schmielau: "[patch,rfc] make depencies on header files explicit"
Previous message: Manfred Spraul: "usb storage cleanup"
In reply to: Manfred Spraul: "usb storage cleanup"
Next in thread: Manfred Spraul: "Re: usb storage cleanup"
Reply: Manfred Spraul: "Re: usb storage cleanup"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

I don't understand what this patch is trying to do...

You're reverting our new state machine changes... why?

You're reverting the new mechanism to determine device state... why?

You're removing the entire bus_reset() logic... why?

This patch undoes most of the work done in the last few months. I
_strongly_ oppose the patch without some better explanations.

About the only think I agree with is the addition of some BUG_ON() calls.

Matt

-- Matthew Dharm Home: mdharm-usb@one-eyed-alien.net Maintainer, Linux USB Mass Storage Driver

I need a computer? -- Customer User Friendly, 2/19/1998

application/pgp-signature attachment: stored

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Next message: Tim Schmielau: "[patch,rfc] make depencies on header files explicit"
Previous message: Manfred Spraul: "usb storage cleanup"
In reply to: Manfred Spraul: "usb storage cleanup"
Next in thread: Manfred Spraul: "Re: usb storage cleanup"
Reply: Manfred Spraul: "Re: usb storage cleanup"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Sun Jul 07 2002 - 22:00:11 EST