Re: [PATCH] Re: Disk IO statistics still buggy

From: Jens Axboe (axboe@kernel.org)
Date: Fri Jul 12 2002 - 00:46:32 EST


On Tue, Jul 09 2002, Jochen Suckfuell wrote:
> --- linux/drivers/scsi/scsi_lib.c Mon Jul 8 16:15:27 2002
> +++ linux_work/drivers/scsi/scsi_lib.c Tue Jul 9 17:56:39 2002
> @@ -426,7 +426,9 @@
> if (req->waiting != NULL) {
> complete(req->waiting);
> }
> + spin_lock_irq(&io_request_lock);
> req_finished_io(req);
> + spin_unlock_irq(&io_request_lock);
> add_blkdev_randomness(MAJOR(req->rq_dev));
>
> SDpnt = SCpnt->device;

good spotting, that's definitely a bug

-- 
Jens Axboe

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Mon Jul 15 2002 - 22:00:22 EST