Re: [CHECKER] 56 potential lock/unlock bugs in 2.5.8

From: Roman Zippel (zippel@linux-m68k.org)
Date: Fri Jul 12 2002 - 12:40:35 EST


Hi,

On Thu, 11 Jul 2002, Thunder from the hill wrote:

> --- fs/affs/namei.c 19 Jun 2002 02:11:51 -0000 1.1.1.1
> +++ fs/affs/namei.c 11 Jul 2002 22:36:41 -0000
> @@ -345,10 +345,14 @@ affs_rmdir(struct inode *dir, struct den
> lock_kernel();
>
> /* WTF??? */
> + res = -ENOENT;
> +
> if (!dentry->d_inode)
> - return -ENOENT;
> + goto out_unlock;
>
> res = affs_remove_header(dentry);
> +
> + out_unlock:
> unlock_kernel();
> return res;
> }

Please drop this patch, it's impossible to hit this problem and I have a
better patch for this.

bye, Roman

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Mon Jul 15 2002 - 22:00:23 EST