Re: [PATCH] agpgart splitup and cleanup for 2.5.25

From: Linus Torvalds (torvalds@transmeta.com)
Date: Mon Jul 15 2002 - 00:38:59 EST


In article <20020711230222.GA5143@kroah.com>, Greg KH <greg@kroah.com> wrote:
>
>Here's the diffstat output of it:
> drivers/char/Config.help | 87
> drivers/char/Config.in | 15
> drivers/char/agp/Config.help | 88
> drivers/char/agp/Config.in | 14
> drivers/char/agp/Makefile | 13
> drivers/char/agp/agp.h | 348 +-
> drivers/char/agp/agpgart_be-ali.c | 265 ++
> drivers/char/agp/agpgart_be-amd.c | 408 +++
> drivers/char/agp/agpgart_be-hp.c | 394 +++
> drivers/char/agp/agpgart_be-i460.c | 595 ++++
> drivers/char/agp/agpgart_be-i810.c | 594 ++++
> drivers/char/agp/agpgart_be-i8x0.c | 720 +++++
> drivers/char/agp/agpgart_be-sis.c | 142 +
> drivers/char/agp/agpgart_be-sworks.c | 626 +++++
> drivers/char/agp/agpgart_be-via.c | 151 +

Ok, so is there any real _reason_ to have filenames quite this ugly?

I'd love to have agp split up sanely, but "sanely" does imply that a via
driver is called "via.c", since the "be" part ("backend") is completely
silly (of _course_ a chipset driver is a "backend" driver, it sure as
hell aint frontend), and that "agpgart_" prefix is kind of silly, since
the whole subdirectory is clearly about AGP.

Having filenames that repeat is redundant, excessive, exorbitant, and
superfluous.

If you want the redundancy, duplication and profusion, please keep it
shorter. And put it at the end, so that at least filename completion
works well: "via-agp.c".

Ok?

                                Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Mon Jul 15 2002 - 22:00:29 EST