Re: [PATCH] agpgart splitup and cleanup for 2.5.25

From: Jeff Garzik (jgarzik@mandrakesoft.com)
Date: Mon Jul 15 2002 - 11:42:53 EST


Dave Jones wrote:
> On Mon, Jul 15, 2002 at 05:38:59AM +0000, Linus Torvalds wrote:
> > > drivers/char/agp/agpgart_be-via.c | 151 +
> > Ok, so is there any real _reason_ to have filenames quite this ugly?
>
> of course not. I'll fix it up later, and send an updated patch
> with 1-2 other small changes that happened since Greg's work
> (one of the Intel backends had a subtle thinko brought forward
> from 2.4.19rc1)
>
> > If you want the redundancy, duplication and profusion, please keep it
> > shorter. And put it at the end, so that at least filename completion
> > works well: "via-agp.c".
> >
> > Ok?
>
> Ok, I think we can even do away with the -agp, as we're in the
> agp/ dircetory, which again seems to be pointless duplication.

modprobe is still a flat namespace :/ So it's not necessarily pointless
duplication. That's why I named the via82cxxx audio driver with the
_audio suffix, to eliminate conflicts with drivers/ide/via82cxxx.c
when/if it becomes directly modprobe-able.

        Jeff

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Mon Jul 15 2002 - 22:00:30 EST