Re: [RFC] Rearranging struct dentry for cache affinity

From: Rusty Russell (rusty@rustcorp.com.au)
Date: Tue Jul 16 2002 - 19:04:44 EST


In message <Pine.GSO.4.21.0207160036460.24417-100000@weyl.math.psu.edu> you wri
te:
> On Tue, 16 Jul 2002, Rusty Russell wrote:
>
> > Really? Other than changing over to get_sb_psuedo(), what does your patch
> > fix? As the filesystem should never be unmounted, what am I missing?
> > > filp->f_op = &futex_fops;
> > > - filp->f_dentry = dget(futex_dentry);
> > > + filp->f_vfsmnt = mntget(futex_mnt);
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> > > + filp->f_dentry = dget(futex_mnt->mnt_root);
>
> Uninitialized ->f_vfsmnt == quite a few places in the tree very unhappy.
> E.g. any access to /proc/<pid>/fd/<n>.

I figured out which ones I needed to set by rough inspection, always a
dangerous practice.

Thanks!
Rusty.

--
  Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Tue Jul 23 2002 - 22:00:21 EST