[patch 2/13] leave truncate's orphaned pages on the LRU

From: Andrew Morton (akpm@zip.com.au)
Date: Wed Jul 17 2002 - 00:29:26 EST


Fix to the page reclaim code from Rik.

Anonymous pages which have buffers arise when
truncate_complete_page()'s call to ->releasepage() failed. Those pages
may still be mapped into process address spaces.

We should not remove them from the LRU, because that makes them
unswappable and they hang around until process exit.

 vmscan.c | 12 ++----------
 1 files changed, 2 insertions(+), 10 deletions(-)

--- 2.5.26/mm/vmscan.c~rmap-lru-fix Tue Jul 16 21:46:28 2002
+++ 2.5.26-akpm/mm/vmscan.c Tue Jul 16 21:59:41 2002
@@ -235,19 +235,11 @@ shrink_cache(int nr_pages, zone_t *class
 
                         if (try_to_release_page(page, gfp_mask)) {
                                 if (!mapping) {
- /*
- * We must not allow an anon page
- * with no buffers to be visible on
- * the LRU, so we unlock the page after
- * taking the lru lock
- */
- spin_lock(&pagemap_lru_lock);
- unlock_page(page);
- __lru_cache_del(page);
-
                                         /* effectively free the page here */
+ unlock_page(page);
                                         page_cache_release(page);
 
+ spin_lock(&pagemap_lru_lock);
                                         if (--nr_pages)
                                                 continue;
                                         break;

.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Tue Jul 23 2002 - 22:00:22 EST