Re: [PATCH] 2.5.24 : BusLogic cleanup - architecture dependencies

From: Dale Amon (amon@vnl.com)
Date: Thu Jul 18 2002 - 10:15:16 EST


As noted below, Frank Davis suggests I fire this back into the
list for discussion.

On Thu, Jul 18, 2002 at 11:04:17AM -0400, Frank Davis wrote:
> Dale,
> Here's what I know....
> not all architectures define an 'address' variable in the struct
> scatterlist, so some archs will compile with no problems, others won't.
> If you're using a i386, there isn't an address variable. Here's what I
> suggest....email linux-kernel with the problem report for 2.5.26, and
> explain what I have stated above. I could have a bunch of #ifdef for
> each arch, but thats plain crazy. I'd be interested in what some other
> developers suggest. Sorry, I couldn't provide you a patch.
>
> Regards,
> Frank
>

==============================================================================

Zwane Mwaikambo wrote:
>On Thu, 18 Jul 2002, Dale Amon wrote:
>
>
>>On Mon, Jun 24, 2002 at 01:07:18AM -0400, Frank Davis wrote:
>>
>>>Hello all,
>>> The following patch removes some unneccessary (it seems) typedefs, and
>>>adds in the pci_set_dma_mask() check mentioned in
>>>Documentation/DMA-mapping.txt . Please review.
>>
>
>The driver needs more than just the dma mask set.
>
>
>>Did your Buslogic patch ever get included? I'm still
>>getting errors compiling 2.5.x as of .26 last night:
>
>
>Probably didn't get in because the driver is still not compliant with the
>new kernel requirements for PCI/DMA
>
>
>>BusLogic.c:32: #error Please convert me to Documentation/DMA-mapping.txt
>>BusLogic.c: In function `BusLogic_DetectHostAdapter':
>>BusLogic.c:2841: warning: long unsigned int format, BusLogic_IO_Address_T
>>arg (arg 2)
>>BusLogic.c: In function `BusLogic_QueueCommand':
>>BusLogic.c:3415: structure has no member named `address'
>
>
>That probably wants sg_dma_address()
>
>
>>BusLogic.c: In function `BusLogic_BIOSDiskParameters':
>>BusLogic.c:4141: warning: implicit declaration of function
>>`scsi_bios_ptable'
>>BusLogic.c:4141: warning: assignment makes pointer from integer without a
>>cast
>>make[2]: *** [BusLogic.o] Error 1
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Tue Jul 23 2002 - 22:00:26 EST