Re: Linux-2.5.28

From: Ingo Molnar (mingo@elte.hu)
Date: Thu Jul 25 2002 - 04:59:46 EST


On Thu, 25 Jul 2002, Marcin Dalecki wrote:

> Carefull.... The ATA host controller patches showed that mindless fixing
> would just hide the fact that, [...]

the main.c change was, frankly, trivially broken. The function that called
the unregister function already held the ide_lock. We have a debugging
mechanism to detect such bugs as they happen (the NMI watchdog), so it's
relatively straightforward (of course not easy) to extend the use of
ide_lock.

the more subtle cases are when the code somehow relies on cli()
excluding multiple IRQ contexts and BH contexts for example.

        Ingo

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Tue Jul 30 2002 - 14:00:19 EST