Re: PCI config locking (WAS Re: [RFC/CFT] cmd640 irqlocking fixes)2

From: benh@kernel.crashing.org
Date: Thu Jul 25 2002 - 09:40:05 EST


>> So there seem to be a problem with your patch: pci_config_lock appears
>> to be an x86-only thing that lives deep inside arch/i386/xxx/pci-pc.c
>> (xxx beeing kernel or pci)
>>
>> On the other hand, there is already such a lock provided by
>> drivers/pci/access.c (pci_lock). You should probably fix your patch
>> to use that one. (and eventually get rid of the pci_config_lock
>> in x86, provided I didn't miss something else). But does anybody
>> but x86 uses CMD640 ? :)
>
>Possibly. I don't know. The lock in question we want is the config lock.
>We are issuing configuration cycles so must lock against a parallel
>issue of I/O to the configuration ports.

Well, all config operations are going through the
pci_read/write_config_xxxx in drivers/pci/pci.c or access.c (2.5)
which will take the pci_lock already. Couldn't x86 use that instead
of stacking another lock ?

Ben.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Tue Jul 30 2002 - 14:00:20 EST