Re: [PATCH] drivers/ide/qd65xx: no cli/sti (2.4.19-pre3 & 2.5.28)

From: Zwane Mwaikambo (zwane@linuxpower.ca)
Date: Thu Jul 25 2002 - 10:47:50 EST


On Thu, 25 Jul 2002, Samuel Thibault wrote:

> static void qd_write_reg (byte content, byte reg)
> {
> unsigned long flags;
>
> - save_flags(flags); /* all CPUs */
> - cli(); /* all CPUs */
> + spin_lock_irqsave(&qd_iolock,flags);
> outb(content,reg);

Do we need a lock/cli for that one outb?

> + spin_unlock_irqrestore(&qd_iolock,flags);

        Zwane

-- 
function.linuxpower.ca

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Tue Jul 30 2002 - 14:00:21 EST