On Friday 26 July 2002 19:40, Jesse Barnes wrote:
> On Fri, Jul 26, 2002 at 07:11:28AM +0200, Marcin Dalecki wrote:
> > Well one one place? Every single implementation of the request_fn
> > method from the request_queue_t needs to hold some
> > lock associated with the queue in question.
> >
> > In fact you will find ASSERT_LOCK macros sparnkled through the scsi code
> > already right now. BTW> ASSERT_HOLDS would sound a bit more
> > familiar to some of us.
> >
> > This minor issue asside I think that your idea is a good thing.
>
> Thanks for the pointer. I'll change those assertions over in the
> next revision.
The scsi version is not the same, it's going to need to be changed to
this sensible version.
The original name is better and shorter. I doubt there is anybody who
will not know immediately what MUST_HOLD(&lock) means.
-- Daniel - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Tue Jul 30 2002 - 14:00:26 EST