G'day,
Pete Zaitcev wrote:
>
> My customers complain that using certain canned configurations
> xconfig does not work (naturally, it works with defconfig).
> A problem that I am trying to fix is that it can refuse to
> quit with something like "Variable CONSTANT_M does not exist".
> The necessary "global" is indeed missing.
>
> Can someone knowledgeable (like Chastain) have a look at
> the attached patch?
I don't claim to be knowledgeable, but I can confirm that this is a
real bug and the patch fixes it. Here is the patch re-jigged to apply
cleanly to 2.5.29.
diff -ruN --exclude-from=dontdiff linux-2.5.29-orig/scripts/tkgen.c linux-2.5.29/scripts/tkgen.c
--- linux-2.5.29-orig/scripts/tkgen.c Sun Jul 28 22:34:05 2002
+++ linux-2.5.29/scripts/tkgen.c Sun Jul 28 22:32:23 2002
@@ -625,6 +625,7 @@
if ( ! vartable[i].global_written )
{
global( vartable[i].name );
+ vartable[i].global_written = 1;
}
printf( "\t" );
}
@@ -696,6 +697,19 @@
}
break;
}
+ }
+
+ /*
+ * Generate global declarations for the dependency chain (e.g. CONSTANT_M).
+ */
+ for ( tmp = cfg->depend; tmp; tmp = tmp->next )
+ {
+ int i = get_varnum( tmp->name );
+ if ( ! vartable[i].global_written )
+ {
+ global( vartable[i].name );
+ vartable[i].global_written = 1;
+ }
}
/*
Greg.
-- the price of civilisation today is a courageous willingness to prevail, with force, if necessary, against whatever vicious and uncomprehending enemies try to strike it down. - Roger Sandall, The Age, 28Sep2001. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Tue Jul 30 2002 - 14:00:28 EST