superfluous hardirq_endlock in bh_action

• Next message: Andrew Morton: "Re: [patch 2/13] remove pages from the LRU in __free_pages_ok()"
• Previous message: David S. Miller: "Re: [patch 2/13] remove pages from the LRU in __free_pages_ok()"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

It looks to me like the call to hardirq_endlock in bh_action is
superfluous, since it doesn't match up with any hardirq_trylock call
that I could see. Perhaps it should be removed?

Paul.

diff -urN linux-2.5/kernel/softirq.c pmac-2.5/kernel/softirq.c
--- linux-2.5/kernel/softirq.c Sun Jul 28 22:47:57 2002
+++ pmac-2.5/kernel/softirq.c Mon Jul 29 12:29:34 2002
@@ -293,7 +293,6 @@
         if (bh_base[nr])
                 bh_base[nr]();
 
- hardirq_endlock();
         spin_unlock(&global_bh_lock);
         return;
 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

• Next message: Andrew Morton: "Re: [patch 2/13] remove pages from the LRU in __free_pages_ok()"
• Previous message: David S. Miller: "Re: [patch 2/13] remove pages from the LRU in __free_pages_ok()"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Tue Jul 30 2002 - 14:00:31 EST