Re: [patch 2/13] remove pages from the LRU in __free_pages_ok()

From: Linus Torvalds (torvalds@transmeta.com)
Date: Sun Jul 28 2002 - 23:28:32 EST


On Sun, 28 Jul 2002, Andrew Morton wrote:
>
> I don't think it can happen in 2.4. In the truncate case,
> the page is taken off the LRU by hand. If do_flushpage()
> failed then the buffers still have a ref on the page, which
> is undone in shrink_cache(), inside pagemap_lru_lock.
>
> So, probably safe, but way too subtle.

That was by no means "subtle", it was all very much "design".

Just undo the broken patch by Rik, and we should all be home free again.

                Linus

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Tue Jul 30 2002 - 14:00:31 EST