Re: [PATCH] lock assertion macros for 2.5.30

From: Jesse Barnes (jbarnes@sgi.com)
Date: Thu Aug 08 2002 - 12:08:24 EST


On Thu, Aug 08, 2002 at 08:00:45AM +0200, Jens Axboe wrote:
> The SCSI ASSERT_LOCK() were never used from kernel space, they are for
> the user space similator. So it was always single threaded from there
> and has no bearing on what actual kernel code does.
>
> For MUST_NOT_HOLD to work, you need to take into account which processor
> took the lock etc.

That's the only way it seems to be useful...

> > After I posted the last patch, a few people asked for MUST_NOT_HOLD so
> > I added it back in. Do you think it's a bad idea? See the last
>
> Your current version is surely worthless.

Agreed. I'll post another patch that doesn't mess with the scsi
stuff. Maybe later I can put together a useful
'lock-not-held-on-this-cpu' macro.

Thanks,
Jesse
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Thu Aug 15 2002 - 22:00:16 EST