Re: [PATCH]2.4.20 ARCH=i386 create dmi_scan.h and move decl from dmi_scan.c

From: Alan Cox (alan@lxorguk.ukuu.org.uk)
Date: Tue Aug 13 2002 - 07:13:04 EST


On Tue, 2002-08-13 at 06:50, Albert Cranford wrote:
> -
> -static char *dmi_ident[DMI_STRING_MAX];
> +char *dmi_ident[DMI_STRING_MAX];

Be very careful with this change btw. The dmi_ident strings are unmapped
at the point dmi_table() returns. That means you can only use them in
the decode callback, and so it seems odd to export them. It certainly
wants clear documentation if you are doing it that way.

What you probably should do is create some flag bits for i2c/smbus and
set those then export the flag data (we do the same for APM), rather
than export them as globals

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Thu Aug 15 2002 - 22:00:31 EST