Re: [PATCH] fix bug in yield()

From: Hiroshi Takekawa (sian@big.or.jp)
Date: Mon Aug 19 2002 - 06:43:42 EST


Hi.

> This patch makes yield() actually call schedule.

The trouble hanging after "Initializing RT netlink socket" which
several report, just gone. And seems to work fine.

But I wonder whether doing schedule() here is good or not. In 2.5,
schedule() is done in sys_sched_yield(). I don't know much about
kernel things. So I just compared...

--
Hiroshi Takekawa <sian@big.or.jp>

> Without this patch, 2.4.20-pre3 will hang on boot for me, looping in > spawn_ksoftirqd waiting for ksoftirqd to start and calling yield(). > ksoftirqd never gets to run, however, because yield never actually > calls schedule. (Note that sys_sched_yield as a syscall is OK because > the syscall exit path will check current->need_resched and call > schedule).

> Paul.

> diff -urN linux-2.4/kernel/sched.c pmac/kernel/sched.c > --- linux-2.4/kernel/sched.c Wed Aug 7 18:10:01 2002 > +++ pmac/kernel/sched.c Mon Aug 19 10:39:39 2002 > @@ -1081,6 +1081,7 @@ > { > set_current_state(TASK_RUNNING); > sys_sched_yield(); > + schedule(); > } > void __cond_resched(void) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Fri Aug 23 2002 - 22:00:16 EST