Re: [PATCH] rmap bugfix, try_to_unmap

From: Daniel Phillips (phillips@arcor.de)
Date: Mon Aug 19 2002 - 15:23:39 EST


On Monday 19 August 2002 22:15, Rik van Riel wrote:
> On Mon, 19 Aug 2002, Daniel Phillips wrote:
> > On Monday 12 August 2002 16:58, Rik van Riel wrote:
> > > case SWAP_FAIL:
> > > ret = SWAP_FAIL;
> > > - break;
> > > + goto give_up;
> >
> > Yes, I looked at that many times while reading the break as a 'break
> > from loop' every time. Using the same keyword to mean 'stop looping'
> > and 'endcase' was, by any measure, a stupid idea.
>
> What's even more curious is that 'continue' has the exact
> same effect on 'switch' ...

Come to think of it, what you want there is:

         case SWAP_FAIL:
                  return SWAP_FAIL;

-- 
Daniel
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Fri Aug 23 2002 - 22:00:18 EST