RE: mdelay causes BUG, please use udelay

From: Feldman, Scott (scott.feldman@intel.com)
Date: Tue Aug 20 2002 - 19:20:02 EST


> We probably shouldn't be doing this, but we can at least
> avoid the BUG caused by doing an mdelay in interrupt context
> if we change to udelay.

That's BUG is my fault. I put that in there so no one would tempted to call
msec_delay in the interrupt context. As you've discovered, I missed one
case where msec_delay is called in interrupt context: tx_timeout. Dangit!

> - msec_delay(10);
> + usec_delay(10000);

Jeff, 10000 seems on the border of what's OK. If it's acceptable, then
let's go for that. Otherwise, we're going to have to chain several
mod_timer callbacks together to do a controller reset.

-scott
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Fri Aug 23 2002 - 22:00:21 EST