Re: [Lse-tech] [patch] Simple Topology API v0.3 (2/2)

From: Matthew Dobson (colpatch@us.ibm.com)
Date: Thu Aug 22 2002 - 15:45:35 EST

Christoph,
        I've had some comments/flames about that... One of the better suggestions that
I've heard so far is to change it to a /proc interface. I'll probably do that
today and resent the userspace patch. If you (or anyone) has better
suggestions, I'm definitely all ears (or eyes, I suppose ;)!

Cheers!

-Matt

Christoph Hellwig wrote:
> On Thu, Aug 22, 2002 at 12:15:07PM -0700, Matthew Dobson wrote:
>
>>diff -Nur linux-2.5.27-vanilla/kernel/sys.c linux-2.5.27-api/kernel/sys.c
>>--- linux-2.5.27-vanilla/kernel/sys.c Sat Jul 20 12:11:07 2002
>>+++ linux-2.5.27-api/kernel/sys.c Wed Jul 24 17:33:41 2002
>>@@ -20,6 +20,7 @@
>> #include <linux/device.h>
>> #include <linux/times.h>
>> #include <linux/security.h>
>>+#include <linux/topology.h>
>>
>> #include <asm/uaccess.h>
>> #include <asm/io.h>
>>@@ -1236,6 +1237,31 @@
>> mask = xchg(&current->fs->umask, mask & S_IRWXUGO);
>> return mask;
>> }
>>+
>>+asmlinkage long sys_check_topology(int convert_type, int to_convert)
>>+{
>>+ int ret = 0;
>>+
>>+ switch (convert_type) {
>>+ case CPU_TO_NODE:
>>+ ret = cpu_to_node(to_convert);
>>+ break;
>>+ case MEMBLK_TO_NODE:
>>+ ret = memblk_to_node(to_convert);
>>+ break;
>>+ case NODE_TO_NODE:
>>+ ret = node_to_node(to_convert);
>>+ break;
>>+ case NODE_TO_CPU:
>>+ ret = node_to_cpu(to_convert);
>>+ break;
>>+ case NODE_TO_MEMBLK:
>>+ ret = node_to_memblk(to_convert);
>>+ break;
>>+ }
>>+
>>+ return (long)ret;
>>+}
>
>
> You don't consider this a proper syscall API, do you?
>
>

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

This archive was generated by hypermail 2b29 : Fri Aug 23 2002 - 22:00:25 EST