Re: [PATCH] make raid5 checksums preempt-safe

From: Brian Gerst (bgerst@didntduck.org)
Date: Mon Aug 26 2002 - 17:33:27 EST

Next message: Itai Nahshon: "[OT] unable to umount ... device busy"
Previous message: sridhar vaidyanathan: "2.4.0 sys_unlink"
In reply to: Robert Love: "[PATCH] make raid5 checksums preempt-safe"
Next in thread: Horst von Brand: "Re: [PATCH] make raid5 checksums preempt-safe"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Robert Love wrote:
> Linus,
>
> The raid5 xor checksums use MMX/SSE state and are not preempt-safe.
>
> Attached patch disables preemption in FPU_SAVE and XMMS_SAVE and
> restores it in FPU_RESTORE and XMMS_RESTORE - preventing preemption
> while in fp mode.
>
> Please, apply.
>
> Robert Love

Use kernel_fpu_begin() and kernel_fpu_end() instead of reinventing the
wheel. The current code is broken wrt SSE as well.

-- Brian Gerst

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Next message: Itai Nahshon: "[OT] unable to umount ... device busy"
Previous message: sridhar vaidyanathan: "2.4.0 sys_unlink"
In reply to: Robert Love: "[PATCH] make raid5 checksums preempt-safe"
Next in thread: Horst von Brand: "Re: [PATCH] make raid5 checksums preempt-safe"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Sat Aug 31 2002 - 22:00:18 EST