Re: [PATCH] sched.c

From: Daniel Phillips (phillips@arcor.de)
Date: Tue Aug 27 2002 - 19:47:24 EST

Next message: David S. Miller: "Re: Bug in kernel code?"
Previous message: Stephen C. Biggs: "Re: [PATCH] sched.c"
In reply to: Daniel Phillips: "Re: [PATCH] sched.c"
Next in thread: Stephen C. Biggs: "Re: [PATCH] sched.c"
Reply: Stephen C. Biggs: "Re: [PATCH] sched.c"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Wednesday 28 August 2002 02:13, Daniel Phillips wrote:
> On Tuesday 27 August 2002 20:35, Andrew Morton wrote:
> > Lahti Oy wrote:
> > > - for (i = 0; i < NR_CPUS; i++)
> > > + for (i = NR_CPUS; i; i--)
> > > sum += cpu_rq(i)->nr_running;
> >
> > Off-by-one there. You'd want
> >
> > for (i = NR_CPUS; --i >= 0; )
> >
> > or something similarly foul ;)
>
> int i = NR_CPUS;
>
> while (--i)

Err, i--

-- 
Daniel
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Next message: David S. Miller: "Re: Bug in kernel code?"
Previous message: Stephen C. Biggs: "Re: [PATCH] sched.c"
In reply to: Daniel Phillips: "Re: [PATCH] sched.c"
Next in thread: Stephen C. Biggs: "Re: [PATCH] sched.c"
Reply: Stephen C. Biggs: "Re: [PATCH] sched.c"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Sat Aug 31 2002 - 22:00:21 EST