> - changes the migration code to use struct completion. Andrew pointed out
> that there might be a small window in where the up() touches the
> semaphore while the waiting task goes on and frees its stack. And
> completion is more suited for this kind of stuff anyway.
actually, i think the race does not exist. up() is perfectly safely done
on the on-stack semaphore, because both the wake_up() done by __up() and
the __down() path takes the waitqueue spinlock, so i cannot see where the
up() touches the semaphore after the down()-ed task has been woken up.
the second argument still holds though - a completion is probably slightly
cheaper in this case.
Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Sat Aug 31 2002 - 22:00:30 EST