Re: One more bio for for floppy users in 2.5.33..

From: Mikael Pettersson (mikpe@csd.uu.se)
Date: Tue Sep 03 2002 - 15:57:32 EST


Linus Torvalds writes:
>
> Ok,
> I found another major bio-related bug that definitely explains why the
> floppy driver generated corruption - any partial request completion would
> be totally messed up by the BIO layer (not the floppy driver).
>
> Any other block device driver that did partial request completion might
> also be impacted.
>
> I'm still looking at the floppy driver itself - some of the request
> completion code is so messed up as to be unreadable, and some of that may
> actually be due to trying to work around the bio problem (unsuccessfully,
> I may add). So this may not actually fix things for you yet, simply
> because the floppy driver itself still does some strange things.

Confirmed. 2.5.33 + your two patches still corrupts data on a simple
dd to then from /dev/fd0 test.

/Mikael
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sat Sep 07 2002 - 22:00:19 EST