Re: [reiserfs-dev] Re: [PATCH] sparc32: wrong type of nlink_t

From: Dave Kleikamp (shaggy@austin.ibm.com)
Date: Thu Sep 05 2002 - 11:09:12 EST


On Thursday 05 September 2002 04:54, Oleg Drokin wrote:

> +/* Find maximal number, that nlink_t can hold. GCC is able to
> calculate this + value at compile time, so do not worry about extra
> CPU overhead. */ +#define REISERFS_LINK_MAX ((((nlink_t) -1) >> 0)?~0:((1u<<(sizeof(nlink_t)*8-1))-1))

Shouldn't this be:

#define REISERFS_LINK_MAX ((((nlink_t) -1) >> 0)?(nlink_t) ~0:((1u<<(sizeof(nlink_t)*8-1))-1))

if nlink_t is u16, ~0 would still be 0xffffffff (assuming 32 bits)

-- 
David Kleikamp
IBM Linux Technology Center

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sat Sep 07 2002 - 22:00:25 EST