Re: 2.4.20pre5aa1

From: Andrea Arcangeli (andrea@suse.de)
Date: Thu Sep 05 2002 - 14:06:00 EST


On Thu, Sep 05, 2002 at 07:48:24PM +0100, Christoph Hellwig wrote:
> On Thu, Sep 05, 2002 at 08:41:25PM +0200, Andrea Arcangeli wrote:
> > other fs, if you're not holding the i_sem (and you certainly aren't
> > holding the i_sem that frequently, you don't even for writes).
>
> Except of O_DIRECT writes we _do_ hold i_sem, btw.

can't you end with this?

                                        O_DIRECT write
                                        write finishes
        truncate drops the write
        truncate set i_sem to 0
                                        write set i_sem to something

and the fs is then corrupt? (very minor corruption of course and
extremely hard to trigger, trivially solvable by an fsck, ext[23] had
similar issues too with the get_block failures with < PAGE_SIZE
softblocksize, fixed around 2.4.19, that was certainly easier to
reproduce btw)

Andrea
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sat Sep 07 2002 - 22:00:26 EST