Re: [patch] ptrace-fix-2.5.33-A1

From: Daniel Jacobowitz (dan@debian.org)
Date: Thu Sep 05 2002 - 18:02:50 EST


On Fri, Sep 06, 2002 at 12:35:22AM +0200, Ingo Molnar wrote:
>
> there are two kinds of wait4 calls, one that gets the WIFSTOPPED event
> from the debugged task, for this the traced task has to be in the
> debugger's ->children list.
>
> Another one is when a debugged task exits and its parent wants the exit
> event. But in this case the task is untraced already, so it gets back into
> the parent's ->children list.
>
> ie. wait4 should only look at the ->children list - zombies (or traced
> tasks debugged by this task) can only be there.
>
> The only addition is that in the wait4 non-blocking case we need to look
> at the traced list as well - since a non-blocking wait4 is a 'could there
> be any children exiting' kind of query.

OK. I think that the !list_empty (ptrace_children) isn't really enough
- since there can be things on our children list that we will not wait
for - should we be iterating over it making the same checks we do
above?

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sat Sep 07 2002 - 22:00:27 EST