Re: [PATCH] IDE cleanup (1.612) broke all fdisks I have...

From: Alexander Viro (viro@math.psu.edu)
Date: Thu Sep 05 2002 - 18:39:21 EST


On Thu, 5 Sep 2002, Petr Vandrovec wrote:

> Hi Al,
> it is nice that blkdev_ioctl calls blk_ioctl itself, but unfortunately
> it does that only if driver's ioctl returns -EINVAL - and IDE returns -EIO :-(
>
> Patch below is tested for disks - I do not have IDE floppy nor IDE tape.

For ide-disk.c, ide-floppy.c and ide-cd.c patch is OK. For ide-tape.c...
Not needed.

Keep in mind that current setup (some ioctls are unconditionally done
in fs/block_dev.c, for some we only call driver, for some - give
driver a chance and do our thing if it doesn't recongnize the ioctl)
will change. Most of the 3rd group actually belong to the 1st one -
the only reason why they are not there is handling of unpartitioned
devices that don't have gendisks. When that gets fixed, the kludge
with calling driver and handling -EINVAL will disappear...

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sat Sep 07 2002 - 22:00:27 EST